Fix payment information never appearing for certain locales#360
Open
x3ro wants to merge 1 commit intolplotni:masterfrom
x3ro:fix-locale-error
Open
Fix payment information never appearing for certain locales#360x3ro wants to merge 1 commit intolplotni:masterfrom x3ro:fix-locale-error
x3ro wants to merge 1 commit intolplotni:masterfrom
x3ro:fix-locale-error
Conversation
The "amount" variable is passed as a string to the template, but then implicitly converted to decimal in `if amount > 0`. This worked for english locales where amount was e.g. `10.00`, but failed for the german locale where amount was e.g. `10,00`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "amount" variable is passed as a string to the template, but
then implicitly converted to decimal in
if amount > 0. This workedfor english locales where amount was e.g.
10.00, but failedfor the german locale where amount was e.g.
10,00.